Skip to content

N22: Add Naga #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2021
Merged

N22: Add Naga #641

merged 2 commits into from
May 31, 2021

Conversation

kvark
Copy link
Collaborator

@kvark kvark commented May 31, 2021

Part of #640

@AngelOnFira AngelOnFira self-requested a review May 31, 2021 16:41
@ozkriff ozkriff changed the title Add Naga to n22 N22: Add Naga May 31, 2021
ozkriff
ozkriff requested changes May 31, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please convert the section to a third-person perspective and swap the image and the rest paragraph according to the template?

@kvark
Copy link
Collaborator Author

kvark commented May 31, 2021

Thanks for pointing this out! Done now.

ozkriff
ozkriff approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit 9724544 into rust-gamedev:source May 31, 2021
@kvark kvark deleted the naga branch May 31, 2021 18:12
@ozkriff ozkriff mentioned this pull request Jun 1, 2021
Closed
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvark @ozkriff @17cupsofcoffee